Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a Service is instantiated UberProto is calling the wrong create method #1

Closed
ekryski opened this issue Apr 27, 2013 · 2 comments
Closed

When a Service is instantiated UberProto is calling the wrong create method #1

ekryski opened this issue Apr 27, 2013 · 2 comments
Labels
Bug

Comments

@ekryski
Copy link
Contributor

ekryski commented Apr 27, 2013

I am trying to expose the services the same way as the providers. It doesn't work because when we are instantiating a service we are calling the "create" function which we have overridden. Refer to https://github.com/ekryski/feathry/commit/8b37fdc14b047e1a9aebdbba97adafad76a62c65#L1L13
@daffl
Copy link
Member

daffl commented Apr 27, 2013

Yeah, I noticed that, too. You'd have to call Proto.create.call(service, arguments) which is a little clunky. Maybe we can alias it like it's been done with the init method?

@daffl daffl closed this as completed Aug 28, 2013
@daffl daffl mentioned this issue Feb 16, 2016
Closed
daffl pushed a commit that referenced this issue Aug 21, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
f76d37a 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl pushed a commit that referenced this issue Aug 22, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
5c3a265 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl pushed a commit that referenced this issue Aug 22, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
b830185 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl pushed a commit that referenced this issue Aug 22, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
e36a419 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl pushed a commit that referenced this issue Aug 23, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
dfeaa6d 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl pushed a commit that referenced this issue Aug 23, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#1)
cba2c59 
* chore(package): update dependencies

* docs(readme): add Greenkeeper badge
daffl added a commit that referenced this issue Aug 25, 2018
@daffl
Merge pull request #1 from marshallswain/patch-1
7c92617 
Typo Fix.
daffl pushed a commit that referenced this issue Aug 25, 2018
@Glavin001 @daffl
Closes #1. First working version.
127e009
daffl pushed a commit that referenced this issue Aug 29, 2018
@ekryski @daffl
Merge pull request #1 from feathersjs/option-from-global-config
d7e9d30 
pulling options for strategy from global auth config
daffl pushed a commit that referenced this issue Aug 29, 2018
@ekryski @daffl
Merge pull request #1 from feathersjs/option-from-global-config
66889b7 
pulling options for strategy from global auth config
@nickerlan nickerlan mentioned this issue Oct 14, 2018
Closed
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @ekryski