Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert database adapters to support promises. #164

Closed
1 of 7 tasks
ekryski opened this issue Nov 4, 2015 · 5 comments
Closed
1 of 7 tasks

Convert database adapters to support promises. #164

ekryski opened this issue Nov 4, 2015 · 5 comments
Labels
Milestone

Comments

@ekryski
Copy link
Contributor

ekryski commented Nov 4, 2015

I'm not sure whether we should kill callbacks altogether but we should definitely support promises. We could potentially use native promises (since node is now v4+) or we could use bluebird. I'm leaning a bit more towards bluebird.

Database adapters needing converting:

  • mongoose
  • knex
  • waterline
  • sequelize
  • nedb
  • memory
  • mongodb

This should probably also be done at the same time as #125.

@ekryski ekryski added this to the 2.0.0 milestone Nov 4, 2015
@daffl
Copy link
Member

daffl commented Nov 30, 2015

Reference implementation is being worked on at https://github.com/feathersjs/feathers-memory/tree/es6. With the bugfixes in latest Uberproto and Rubberduck it should be fully compatible with Feathers 1.x while supporting ES6 syntax, Promises and pagination.

@ekryski
Copy link
Contributor Author

ekryski commented Nov 30, 2015

👍 Looks like you're using native promises. Totally cool with that as it's less overhead. I'm not sure how Babel translates that, but @daffl do you think this will this have any backwards compatibility issues?

@daffl
Copy link
Member

daffl commented Nov 30, 2015

I thought it inlines the polyfills but apparently you need to add https://babeljs.io/docs/usage/polyfill/ as a dependency.

@daffl
Copy link
Member

daffl commented Dec 16, 2015

This is also being tracked in #170

@daffl daffl closed this as completed Dec 16, 2015
daffl pushed a commit that referenced this issue Aug 29, 2018
daffl pushed a commit that referenced this issue Aug 29, 2018
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants