-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert database adapters to support promises. #164
Comments
Reference implementation is being worked on at https://github.com/feathersjs/feathers-memory/tree/es6. With the bugfixes in latest Uberproto and Rubberduck it should be fully compatible with Feathers 1.x while supporting ES6 syntax, Promises and pagination. |
👍 Looks like you're using native promises. Totally cool with that as it's less overhead. I'm not sure how Babel translates that, but @daffl do you think this will this have any backwards compatibility issues? |
I thought it inlines the polyfills but apparently you need to add https://babeljs.io/docs/usage/polyfill/ as a dependency. |
This is also being tracked in #170 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs. |
I'm not sure whether we should kill callbacks altogether but we should definitely support promises. We could potentially use native promises (since node is now v4+) or we could use bluebird. I'm leaning a bit more towards bluebird.
Database adapters needing converting:
This should probably also be done at the same time as #125.
The text was updated successfully, but these errors were encountered: