Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for services to return a promise instead of a callback #41

Closed
daffl opened this issue Mar 12, 2014 · 3 comments · Fixed by #59
Closed

Add ability for services to return a promise instead of a callback #41

daffl opened this issue Mar 12, 2014 · 3 comments · Fixed by #59
Labels
Milestone

Comments

@daffl
Copy link
Member

daffl commented Mar 12, 2014

If a service returns a Promises/A+ Promise and the callback isn't called, the promise should be used to resolve the request.

var todoService = {
  todos: [],

  // Return all todos from this service
  find: function(params) {
    return Q(this.todos);
  }
}
@Glavin001
Copy link
Contributor

+1

@daffl daffl added this to the 0.4.0 milestone Mar 28, 2014
@daffl daffl removed this from the 0.4.0 milestone Apr 6, 2014
@daffl daffl added this to the 1.0.0 milestone Apr 16, 2014
@pspeter3
Copy link

This would be awesome.

@daffl daffl closed this as completed in #59 Apr 28, 2014
daffl added a commit that referenced this issue Aug 21, 2018
…odule-exports-0.2.0

Update babel-plugin-add-module-exports to version 0.2.0 🚀
daffl added a commit that referenced this issue Aug 21, 2018
…odule-exports-0.2.0

Update babel-plugin-add-module-exports to version 0.2.0 🚀
daffl pushed a commit that referenced this issue Aug 21, 2018
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/
daffl pushed a commit that referenced this issue Aug 22, 2018
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/
daffl added a commit that referenced this issue Aug 25, 2018
daffl added a commit that referenced this issue Aug 28, 2018
daffl added a commit that referenced this issue Aug 28, 2018
* Rename repository and update to npm scope

* Update Codeclimate token
daffl pushed a commit that referenced this issue Aug 29, 2018
* Added support for redirect options on strategy options

* Simplified redirect options. Uses strategy options instead of having a sub-document
daffl added a commit that referenced this issue Aug 29, 2018
daffl added a commit that referenced this issue Aug 29, 2018
* Rename repository and update to npm scope

* Update Codeclimate token
daffl pushed a commit that referenced this issue Aug 29, 2018
* Added support for redirect options on strategy options

* Simplified redirect options. Uses strategy options instead of having a sub-document
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants