Clone Proto to modify and use the copy. #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great idea. Tests are failing, probably because they need |
|
I don't think this is a good idea. Even after removing the Proto.isPrototypeOf() test, EVERY test after the first 10 fails. |
|
It is the right approach though I think. I'll give it a try as well and see what is happening. |
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 24, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Finalizing client side authentication module
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Finalizing client side authentication module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in feathersjs-ecosystem/feathers-mongodb#9, this creates a clone of Proto to be modified.