Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to unshift hooks #1590

Closed
wants to merge 3 commits into from

Conversation

bertho-zero
Copy link
Collaborator

Allow registering of hooks with $unshift and $push like this:

app.hooks({
  before: {
    find: {
      $unshift: someHook()
    }
  }
})

@bertho-zero bertho-zero requested a review from daffl September 28, 2019 12:14
@bertho-zero
Copy link
Collaborator Author

@daffl I think similar functionality is required in @feathersjs/hooks, we may want to define basic hooks at the service level and possibly add a more global validator when integrating the service into the app.

@daffl
Copy link
Member

daffl commented Jan 24, 2020

I opened up a follow-up discussion for this in feathersjs/hooks#11

@daffl
Copy link
Member

daffl commented Mar 4, 2020

I'm going to close this for #1798 (which has passing tests now)

@daffl daffl closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants