feat(authentication-oauth): Set oAuth redirect URL dynamically #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliSadaka
pushed a commit
to yusernetwork/authentication-oauth
that referenced
this pull request
Oct 20, 2020
…ss query the service (feathersjs#1737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set oAuth redirect URL dynamically and pass query into the service
Summary
Update for request #1591
I separated the query and redirect property as the query will be passed in to create or patch methods.
Patch method uses query to update the user and redirect always will be there so devs will need to override patch method to drop redirect from the query.
I found it most convenient but we can add it into the documentation and leave redirect in query