chore(typescript): Migrate @feathersjs/errors to modern classes and TypeScript #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertho-zero
reviewed
Apr 17, 2020
| @@ -3,8 +3,8 @@ | |||
| "description": "Common error types for Feathers apps", | |||
There was a problem hiding this comment.
Why does this package use tabs and spaces?
There was a problem hiding this comment.
I was wondering why it looked odd. Fixed in cbd31c1
|
Cool, I think we should integrate the concept of The problem with |
|
Interesting, I hadn't seen that before. Hoping that this refactoring as a first step combined with the new hooks will also improve error messages (and stack traces). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses modern ES classes for error types and removes undocumented initialization modes and workarounds for browser engines that are no longer supported.