Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows error hooks to swallow error by setting the result #621

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Jul 14, 2017

This allows error hooks to normally resolve by setting hook.result instead of always throwing the error.

Closes feathersjs-ecosystem/feathers-hooks#151

@marshallswain
Copy link
Member

Looks great!

@daffl daffl merged commit 222ba3c into major Jul 14, 2017
@daffl daffl deleted the hook-error branch July 14, 2017 15:14
daffl added a commit that referenced this pull request Aug 29, 2018
* Update readme to line up with latest release

* Also update Readme
daffl added a commit that referenced this pull request Aug 29, 2018
* Update readme to line up with latest release

* Also update Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants