Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): Ensure that all regular error hooks are run #103

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Jun 4, 2022

This pull request ensures that all regular error hooks are executed. Previously it was returning after the first one (since it returned with an error).

@daffl daffl merged commit bbd1979 into main Jun 4, 2022
@daffl daffl deleted the error-hooks branch June 4, 2022 17:23
@daffl
Copy link
Member Author

daffl commented Jun 4, 2022

Related to #97

@marshallswain
Copy link
Member

Is the 4th item from #97 already fixed, @daffl ?

@daffl
Copy link
Member Author

daffl commented Jun 4, 2022

I'm not sure. This might be Feathers core implementation specific. There now is a statusCode getter/setter that aliases to the new http object. I believe Object.assign takes those into consideration but it might need a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants