Skip to content

Commit

Permalink
remove registry fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
aabbasi-hbo committed Nov 10, 2022
1 parent 858f362 commit 78695d1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 42 deletions.
34 changes: 0 additions & 34 deletions feathr_project/feathr/registry/_feathr_registry_client_aws.py

This file was deleted.

8 changes: 2 additions & 6 deletions feathr_project/feathr/registry/feature_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,10 @@ def save_to_feature_config_from_context(self, anchor_list, derived_feature_list,
def default_registry_client(project_name: str, config_path:str = "./feathr_config.yaml", project_registry_tag: Dict[str, str]=None, credential = None) -> FeathrRegistry:
from feathr.registry._feathr_registry_client import _FeatureRegistry
from feathr.registry._feature_registry_purview import _PurviewRegistry
from feathr.registry._feathr_registry_client_aws import _FeatureRegistryAWS
from aws_requests_auth.aws_auth import AWSRequestsAuth


envutils = _EnvVaraibleUtil(config_path)
registry_endpoint = envutils.get_environment_variable_with_default("feature_registry", "api_endpoint")
if registry_endpoint and isinstance(credential, AWSRequestsAuth):
return _FeatureRegistryAWS(project_name, endpoint=registry_endpoint, project_tags=project_registry_tag, credential=credential)
elif registry_endpoint:
if registry_endpoint:
return _FeatureRegistry(project_name, endpoint=registry_endpoint, project_tags=project_registry_tag, credential=credential)
else:
registry_delimiter = envutils.get_environment_variable_with_default('feature_registry', 'purview', 'delimiter')
Expand Down
3 changes: 1 addition & 2 deletions feathr_project/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@
# it brings a different version of msrest(0.7.0) which is incompatible with azure-core==1.22.1. Hence we need to pin it.
# See this for more details: https://github.com/Azure/azure-sdk-for-python/issues/24765
"msrest<=0.6.21",
"typing_extensions>=4.2.0",
"aws-requests-auth>=0.4.3"
"typing_extensions>=4.2.0"
],
tests_require=[ # TODO: This has been depricated
"pytest",
Expand Down

0 comments on commit 78695d1

Please sign in to comment.