[Urgent] Fix previous key vault PR typo (#223)

Fix typo
feathr-ai · May 5, 2022 · 7efc841 · 7efc841
1 parent 1d3f793
commit 7efc841
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/feathr_project/feathr/_envvariableutil.py b/feathr_project/feathr/_envvariableutil.py
@@ -65,7 +65,9 @@ def get_environment_variable(variable_key):
         if not password:
             logger.info(variable_key +
                         ' is not set in the environment variables, fetching the value from Key Vault')
-            akv_name = os.env.get("KEY_VAULT_NAME")
-            akv_client = AzureKeyVaultClient(akv_name)
-            password = akv_client.get_akv_secret(variable_key)
+            akv_name = os.environ.get("KEY_VAULT_NAME")
+            if akv_name:
+                akv_client = AzureKeyVaultClient(akv_name)
+                password = akv_client.get_akv_secret(variable_key)
         return password
+
diff --git a/feathr_project/feathr/akv_client.py b/feathr_project/feathr/akv_client.py
@@ -11,7 +11,7 @@ def __init__(self, akv_name: str):
     def get_akv_secret(self, secret_name: str):
         if self.secret_client is None:
             self.secret_client = SecretClient(
-                vault_uri = f"https://{self.akv_name}.vault.azure.net",
+                vault_url = f"https://{self.akv_name}.vault.azure.net",
                 credential=DefaultAzureCredential()
             )
         try: