Skip to content

Commit

Permalink
#492 fix, fail only if different sources have same name (#733)
Browse files Browse the repository at this point in the history
  • Loading branch information
windoze authored Oct 11, 2022
1 parent a325597 commit bb67939
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion feathr_project/feathr/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def build_features(self, anchor_list: List[FeatureAnchor] = [], derived_feature_
f"definitions. Anchor name of {anchor} is already defined in {anchor_names[anchor.name]}")
else:
anchor_names[anchor.name] = anchor
if anchor.source.name in source_names:
if anchor.source.name in source_names and (anchor.source is not source_names[anchor.source.name]):
raise RuntimeError(f"Source name should be unique but there are duplicate source names in your source "
f"definitions. Source name of {anchor.source} is already defined in {source_names[anchor.source.name]}")
else:
Expand Down

0 comments on commit bb67939

Please sign in to comment.