Skip to content

Commit

Permalink
Fix delete entity function bug for #852 (#952)
Browse files Browse the repository at this point in the history
  • Loading branch information
Yuqing-cat committed Jan 10, 2023
1 parent c967f6d commit be81c3f
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions registry/access_control/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ async def get_project(project: str, response: Response, access: UserAccess = Dep
headers=get_api_header(access.user_name)))
return res


@router.get("/dependent/{entity}", name="Get downstream/dependent entitites for a given entity [Read Access Required]")
def get_dependent_entities(entity: str, access: UserAccess = Depends(project_read_access)):
response = requests.get(url=f"{registry_url}/dependent/{entity}",
headers=get_api_header(access.user_name)).content.decode('utf-8')
return json.loads(response)


@router.get("/projects/{project}/datasources", name="Get data sources of my project [Read Access Required]")
def get_project_datasources(project: str, response: Response, access: UserAccess = Depends(project_read_access)) -> list:
response.status_code, res = check(requests.get(url=f"{registry_url}/projects/{project}/datasources",
Expand Down Expand Up @@ -62,10 +64,13 @@ def get_feature(feature: str, response: Response, requestor: User = Depends(get_
feature_qualifiedName, requestor, AccessType.READ)
return res


@router.delete("/entity/{entity}", name="Deletes a single entity by qualified name [Write Access Required]")
def delete_entity(entity: str, access: UserAccess = Depends(project_write_access)) -> str:
requests.delete(url=f"{registry_url}/entity/{feature}",
headers=get_api_header(access.user_name)).content.decode('utf-8')
def delete_entity(entity: str, response: Response, access: UserAccess = Depends(project_write_access)) -> str:
response.status_code, res = check(requests.delete(
url=f"{registry_url}/entity/{entity}", headers=get_api_header(access.user_name)))
return res


@router.get("/features/{feature}/lineage", name="Get Feature Lineage [Read Access Required]")
def get_feature_lineage(feature: str, response: Response, requestor: User = Depends(get_user)) -> dict:
Expand Down

0 comments on commit be81c3f

Please sign in to comment.