Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dummy entries to feathr_config.yaml file for additional library entries #1012

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

jainr
Copy link
Collaborator

@jainr jainr commented Jan 26, 2023

Description

Adding placeholder in feathr_config.yaml file for additional libraries to be passed for databricks.

This is needed since we are now passing more than one library to databricks spark config. Also made a note of the error that folks will get if the size is not defined correctly.

Resolves #1009

How was this PR tested?

Tested it in databricks notebook where I was getting list Index out of bounds exception since the spark config library size was 1.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

jainr added 6 commits January 25, 2023 11:36
… config, and also adding additonal entries to reference feathr_config.yaml file so array is initialized assize 2 if users are just copying from it. Also made a note of the error in the code
@jainr jainr added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 27, 2023
Copy link
Collaborator

@mufajjul mufajjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@jainr jainr merged commit 304de03 into feathr-ai:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range error in NYC Data
3 participants