Fix nyc_taxi data utils bug in databricks path #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
loomlike
added
the
safe to test
blrchen
approved these changes
Feb 9, 2023
|
After your PR, does this custom logic in sample notebook needs to be changed as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Ki Min 42475935+loomlike@users.noreply.github.com
Description
nyc_taxi.get_spark_dfdoesn't parses thelocal_cache_pathargument correctly when it has "/dbfs/" prefix.Previously, "/dbfs/myfile" is parsed as "dbfs:/dbfs/myfile", but it should be "dbfs:/myfile" instead.
This PR fixes this behavior.
How was this PR tested?
Added more unit test cases after the fix.
Does this PR introduce any user-facing changes?