Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feathr Web UI MVP #216

Merged
merged 27 commits into from
May 5, 2022
Merged

Feathr Web UI MVP #216

merged 27 commits into from
May 5, 2022

Conversation

blrchen
Copy link
Collaborator

@blrchen blrchen commented May 4, 2022 •
edited
Loading

This PR initialize the fundamental codebase for feathr web UI development, to support following up UX user stories implementation. The codebase is initialized with Create React App, plus following code implementation:

UX framework related implemented

  • React recommended eslint settings are enabled.
  • Add a workflow for azure container app CI/CD
  • Add React components for global static contents: site layout, menu sidebar, header, footer, etc.

User stories implemented

  • Azure AD Account login
  • Data sources listing
  • List features by project
  • View feature metadata properties
  • View Feature lineage flow chart

Docs

  • A README.md is added under ui directory for general ui dev get start doc

Built on

project license
@azure/msal-browser,@azure/msal-react MIT
antd MIT
axios MIT
dagre MIT
react,react-dom,react-router MIT
react-flow-renderer MIT
react-query MIT
react-resizable MIT

Closes #215

blrchen and others added 20 commits March 30, 2022 11:29
@blrchen
Init react based feathr ui code (#1)
e219d2d
@blrchen
Enables continues integration and deployment to cloud for ui app (#3)
2125737 
This PR enables continues integration and deployment to cloud for ui app

- Manually create azure web app under ACE subscription resource group feathr-ui-test
- Create github action workflow to trigger deployment on main branch push or pull request
- Deploy policy
   - Main branch will be deployed to https://thankful-mud-0addb6c00.1.azurestaticapps.net/
   - Each pull request will be deployed to a staging environment, the url will be generated dynamically n each PR's comment.
@blrchen
Add UI landing page
dae5fc5
@blrchen
Workaround for CI treat warning as error
a4fcb8a
@blrchen
Enable client side route in Azure Static Web App
ba8f242
@blrchen
Code clean up
a171418
@blrchen
Code clean up
f2ae064
@blrchen
Enable eslint rules
3fb99ef
@blrchen
Update README.md
e8c9f00
@blrchen
Fix CI error
fb9886b
@blrchen
Add data source mockup page
0d0ac94
@blrchen
Enable Azure AD login
dfbfad4
@blrchen
Merge branch 'linkedin:main' into main
a2eade0
@blrchen
Merge branch 'main' into blair/landing-page
a3ceffd
@blrchen
Complete api integration
c0cf941
@blrchen
Complete api integration
0829447
@blrchen
Show lineage in feature detail page
00e71a3
@blrchen
Resolve demo review comments
8c433bc
@blrchen
Update page title
cc45acb
@blrchen
Add lineage UI page
13e7611
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/src/api/api.tsx Outdated Show resolved Hide resolved
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/README.md Show resolved Hide resolved
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/public/index.html Outdated Show resolved Hide resolved
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/public/index.html Outdated Show resolved Hide resolved
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/public/index.html Outdated Show resolved Hide resolved
jaymo001
jaymo001 reviewed May 4, 2022
View reviewed changes
ui/public/index.html Outdated Show resolved Hide resolved
@hangfei
Copy link
Collaborator

hangfei commented May 5, 2022 •
edited
Loading

For foundational PRs, a dev guide is required. You can find some examples : https://github.com/linkedin/feathr/tree/main/docs/dev_guide

hangfei
hangfei reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code documentation is needed for future devs. See https://github.com/linkedin/feathr/blob/main/feathr_project/feathr/client.py as an example.

.github/workflows/azure-static-web-apps-thankful-mud-0addb6c00.yml Outdated Show resolved Hide resolved
ui/.eslintrc Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label May 5, 2022
@blrchen blrchen requested a review from windoze May 5, 2022 14:05
windoze
windoze previously approved these changes May 5, 2022
View reviewed changes
@blrchen blrchen added safe to test Tag to execute build pipeline for a PR from forked repo and removed safe to test Tag to execute build pipeline for a PR from forked repo labels May 5, 2022
@hangfei
Copy link
Collaborator

hangfei commented May 5, 2022

Thanks for adding the license description.
In the license section, what's antd?

@blrchen
Copy link
Collaborator Author

blrchen commented May 5, 2022

Thanks for adding the license description. In the license section, what's antd?

Ant Design

@blrchen blrchen added safe to test Tag to execute build pipeline for a PR from forked repo and removed safe to test Tag to execute build pipeline for a PR from forked repo labels May 5, 2022
jaymo001
jaymo001 previously approved these changes May 5, 2022
View reviewed changes
@blrchen blrchen merged commit 11f8ecb into feathr-ai:main May 5, 2022
@blrchen blrchen changed the title Feathr Web UI MVP Prototype Feathr Web UI MVP May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangfei hangfei hangfei left review comments

@jaymo001 jaymo001 jaymo001 approved these changes

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@windoze windoze windoze left review comments

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feathr Web UI MVP
5 participants
@blrchen @hangfei @windoze @xiaoyongzhu @jaymo001