Changing illegal key vault secret name #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuqing-cat
approved these changes
May 9, 2022
|
Could you help review change? @xiaoyongzhu |
xiaoyongzhu
approved these changes
May 10, 2022
|
Thanks for the fix @adityakaul ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the ARM template shown in the Feathr quickstart. Currently, the deploy to azure button fails to deploy because the secret name REDIS_PASSWORD is illegal .Secrets can only contain alphanumeric characters and dashes. Changing it to REDIS-PASSWORD to match the rest of the template. This secret is not used in the jupyter notebook shown in quick start, so does not need to be changed there.