Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feathr UI: redesign site header #260

Merged
merged 3 commits into from
May 17, 2022
Merged

Feathr UI: redesign site header #260

merged 3 commits into from
May 17, 2022

Conversation

blrchen
Copy link
Collaborator

@blrchen blrchen commented May 16, 2022

This PR makes following feathr ui site header changes

  • Display username in header, add avatar
  • Move logout button to a dropdown triggered by hover
  • Shorten site description to make more rooms to site content pages.

Linked issue: #272

@hangfei
Copy link
Collaborator

hangfei commented May 16, 2022

Thanks for the improvements! Could you provide a screenshots of the UI changes? Thanks.

@blrchen
Copy link
Collaborator Author

blrchen commented May 17, 2022

Pls try it with this staging env: https://brave-moss-045d2ce00.1.azurestaticapps.net/

hangfei
hangfei previously approved these changes May 17, 2022
Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the improvements!

# Conflicts:
#	ui/src/router/routes.tsx
@hangfei hangfei requested a review from xiaoyongzhu May 17, 2022 16:47
@xiaoyongzhu xiaoyongzhu merged commit ecadff6 into feathr-ai:main May 17, 2022
@blrchen blrchen deleted the blair/avatar branch May 17, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants