Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixed dependecy problem of pretty print utils #273

Merged
merged 1 commit into from
May 18, 2022

Conversation

ahlag
Copy link
Contributor

@ahlag ahlag commented May 18, 2022

Signed-off-by: Chang Yong Lik theeahlag@gmail.com

Description

  • Placed feathr_project/utils.py -> feathr_project/feathr/utils.py

Resolves #163

How was this patch tested?

Ran pytest -s feathr_project/test/test_feature_materialization.py -k "test_build_feature_verbose" to check the pretty-printed features

Does this PR introduce any user-facing changes?

Fixes dependency problems when install feathr

Signed-off-by: Chang Yong Lik <theeahlag@gmail.com>
@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label May 18, 2022
@xiaoyongzhu xiaoyongzhu merged commit 1750795 into feathr-ai:main May 18, 2022
@xiaoyongzhu
Copy link
Member

Thanks @ahlag !

@ahlag ahlag deleted the hotfix/pretty-print-dependencies branch May 30, 2022 15:16
bozhonghu pushed a commit that referenced this pull request Jun 1, 2022
* main: (30 commits)
  Yihui/moderate registration conflict (#304)
  Update homepage (#310)
  Add extensible extractor APIs (#302)
  Remove Java and JS from Code Scanning
  Create codeql-analysis.yml
  [feathr] Add API to materialize features to offline store (#294)
  Improve error message when path is not supported (#257)
  Add tech talk slides for Feathr (#296)
  Update README.md
  Add milestone link (#286)
  Fix millisecond timestamp handling (#288)
  Consolidating CI pipelines (#280)
  Fixed dependecy problem of pretty print utils (#273)
  Fixing a broken link in README.md (#277)
  Fix test failure (#276)
  Added feature validation (#258)
  Feathr UI: Display feature key and transform expression in feature detail pages (#262)
  Feathr UI: enable multiple tenant auth (#266)
  Reduce feathr web api docker image build time (#261)
  Pretty-print the features produced by buildFeatures  (#214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty-print the features produced by buildFeatures and submit job
4 participants