Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding webapp and webappPlan creation to deployment ARM template #352

Merged
merged 13 commits into from
Jun 23, 2022
Merged

Adding webapp and webappPlan creation to deployment ARM template #352

merged 13 commits into from
Jun 23, 2022

Conversation

jainr
Copy link
Collaborator

@jainr jainr commented Jun 13, 2022

Successful deployment
image

Also adding instructions to create AAD app and to get clientId and TenantId.
Made corresponding changes in tempplate to accept them as parameters and pass it to webapp as settings.

Copy link
Collaborator

@Yuqing-cat Yuqing-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have a "provisionWebApp" parameter to let user decide whether to deploy it or not just like Purview & EventHub?

docs/how-to-guides/azure_resource_provision.json Outdated Show resolved Hide resolved
Yuqing-cat
Yuqing-cat previously approved these changes Jun 15, 2022
@xiaoyongzhu
Copy link
Member

title says it's still WIP so not sure it's ready to take review or not?

But anyway I looked thru the changes and I'm good with those.

@jainr
Copy link
Collaborator Author

jainr commented Jun 20, 2022

title says it's still WIP so not sure it's ready to take review or not?

But anyway I looked thru the changes and I'm good with those.

I had it work in progress, to update the final docker image that we deploy to UI app, currently it's a placeholder.

@jainr jainr changed the title Adding webapp and webappPlan creation to deployment ARM template [[Work in Progress]] Adding webapp and webappPlan creation to deployment ARM template Jun 20, 2022
@jainr jainr merged commit a1743ed into feathr-ai:main Jun 23, 2022
@xiaoyongzhu
Copy link
Member

image
I looked thru the new experience, as above, a few feedbacks:

  1. Docker Image - seems the description is wrong there. Also we should avoid using a specific person's name (like blchen)
  2. Maybe rename "Docker Image" as "Pre-built Feathr UI Docker Image" or something like that so users know what we are talking about
  3. We should probably combine the object ID and this AAD credential together since anyway they need to run thru the scripts

@jainr
Copy link
Collaborator Author

jainr commented Jun 23, 2022

Thanks for the feedback @xiaoyongzhu, I will include that in subsequent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants