-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding webapp and webappPlan creation to deployment ARM template #352
Conversation
…lls a public image from dockerhub. Also fixing a bug to fetch principal id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we have a "provisionWebApp" parameter to let user decide whether to deploy it or not just like Purview & EventHub?
title says it's still WIP so not sure it's ready to take review or not? But anyway I looked thru the changes and I'm good with those. |
I had it work in progress, to update the final docker image that we deploy to UI app, currently it's a placeholder. |
…and appsettings to pass it
Thanks for the feedback @xiaoyongzhu, I will include that in subsequent PR |
https://docs.microsoft.com/en-us/cli/azure/microsoft-graph-migration#breaking-changes
Successful deployment
Also adding instructions to create AAD app and to get clientId and TenantId.
Made corresponding changes in tempplate to accept them as parameters and pass it to webapp as settings.