UDF plugin API #507
Merged
UDF plugin API #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 4, 2022 10:53
…e classes in MVEL expressions
…to FeatureValue. also added tests.
d4ve
force-pushed
the
dstein/udf_plugin_api
branch
from
1d1bb6f
to
1ed56c3
Compare
jaymo001
reviewed
Aug 4, 2022
src/main/scala/com/linkedin/feathr/offline/config/FeathrConfigLoader.scala
Outdated
Show resolved
Hide resolved
d4ve
force-pushed
the
dstein/udf_plugin_api
branch
from
44162f7
to
753b8dd
Compare
d4ve
force-pushed
the
dstein/udf_plugin_api
branch
from
753b8dd
to
b54f6c5
Compare
jaymo001
approved these changes
Aug 8, 2022
xiaoyongzhu
approved these changes
Aug 8, 2022
|
This one looks like a pretty big change but I failed to find and doc/discussion, could anyone help me to point out where to find them? |
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* untested prototype of UDF plugin API * demo of how to enable coercion between different kinds of FeatureValue classes in MVEL expressions * add plugin APIs (untested) * added docs, cleaned up APIs, still working on testing * update how MVEL is invoked, to conditionally apply plugin to convert to FeatureValue. also added tests. * small doc fix * attempted bugfix regarding not holding on to the adapted anchorExtractor object Co-authored-by: David Stein <dstein@dstein-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this API is for advanced users/deployments of Feathr to be able to use their own custom Scala UDF types for their feature anchors. This is intended as a migration aid from previous versions of Feathr (before open sourcing).