Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on registry endpoints related doc #541

Merged
merged 4 commits into from
Aug 7, 2022

Conversation

blrchen
Copy link
Collaborator

@blrchen blrchen commented Aug 1, 2022

This PR updates registry related doc for

  • Deprecate purview configs under feature_registry in docs, replace with endpoint config
  • Update notebook not to use deprecated registry config

@xiaoyongzhu
Copy link
Member

Let's don't deprecate for now as there are a few customers using the existing way (connecting to purview directly from Feathr Client).

@blrchen
Copy link
Collaborator Author

blrchen commented Aug 1, 2022

Let's don't deprecate for now as there are a few customers using the existing way (connecting to purview directly from Feathr Client).

I add back legacy configs and add deprecate soon in description to note new users.

xiaoyongzhu
xiaoyongzhu previously approved these changes Aug 2, 2022
@xiaoyongzhu xiaoyongzhu merged commit 289e329 into main Aug 7, 2022
@xiaoyongzhu xiaoyongzhu deleted the blair/update-registry-doc branch August 7, 2022 07:50
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
* Updates on registry endpoints related doc

* Add back legacy registry configs and call out deprecate soon

* Resolve code review comments

* Enhance deprecation section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants