-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build docker image for feathr #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you please add some documentation (with the screen shot you have in the PR description) under dev_guide explaining your motivation and steps to follow.
Sure, will update docs in this PR |
@jainr I updated dev guide, pls help review, thx |
@YihuiGuo thanks for the PR, can you elaborate on the use case there? Like when would users need this image? |
Which version of the Feathr client is integrated in this image? Can it be directly used in Jupyter notebook or users still need to install it by themselves? |
This image is built for feathr developers, make them able to create ephemeral and independent environment with feathr installed, and with powerful IDE ready to use. |
It is using latest version of feathr . Tested locally, feathr client can be directly used in notebook created by JupyterLab. |
* build docker image for feathr * Add docker guidance to dev guide
This PR builds a docker image with feathr installed, and vscode server / Jupyter lab integrated.
To build the docker image, navigate to feathr root folder ,
To start the docker, you need to specify the port mapping.
8080: vscode server
9090: jupyter lab
credential for jupyter lab and code server is "feathr"