Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build docker image for feathr #554

Merged
merged 2 commits into from
Aug 23, 2022
Merged

build docker image for feathr #554

merged 2 commits into from
Aug 23, 2022

Conversation

YihuiGuo
Copy link
Contributor

@YihuiGuo YihuiGuo commented Aug 4, 2022

This PR builds a docker image with feathr installed, and vscode server / Jupyter lab integrated.

To build the docker image, navigate to feathr root folder ,
image

To start the docker, you need to specify the port mapping.
8080: vscode server
9090: jupyter lab

image

credential for jupyter lab and code server is "feathr"
image
image

jainr
jainr previously approved these changes Aug 8, 2022
Copy link
Collaborator

@jainr jainr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you please add some documentation (with the screen shot you have in the PR description) under dev_guide explaining your motivation and steps to follow.

@YihuiGuo
Copy link
Contributor Author

YihuiGuo commented Aug 8, 2022

Looks good to me, can you please add some documentation (with the screen shot you have in the PR description) under dev_guide explaining your motivation and steps to follow.

Sure, will update docs in this PR

@YihuiGuo
Copy link
Contributor Author

YihuiGuo commented Aug 9, 2022

@jainr I updated dev guide, pls help review, thx

@YihuiGuo YihuiGuo closed this Aug 9, 2022
@YihuiGuo YihuiGuo reopened this Aug 9, 2022
@xiaoyongzhu
Copy link
Member

@YihuiGuo thanks for the PR, can you elaborate on the use case there? Like when would users need this image?

@windoze
Copy link
Member

windoze commented Aug 9, 2022

Which version of the Feathr client is integrated in this image? Can it be directly used in Jupyter notebook or users still need to install it by themselves?

@YihuiGuo
Copy link
Contributor Author

@YihuiGuo thanks for the PR, can you elaborate on the use case there? Like when would users need this image?

This image is built for feathr developers, make them able to create ephemeral and independent environment with feathr installed, and with powerful IDE ready to use.
For example, getting rid of all pre-defined and legacy environment variables, and run feathr tests in a "clean environment".

@YihuiGuo
Copy link
Contributor Author

Which version of the Feathr client is integrated in this image? Can it be directly used in Jupyter notebook or users still need to install it by themselves?

It is using latest version of feathr .
ref RUN pip install git+https://github.com/linkedin/feathr.git#subdirectory=feathr_project

Tested locally, feathr client can be directly used in notebook created by JupyterLab.

@Yuqing-cat Yuqing-cat merged commit 4218542 into feathr-ai:main Aug 23, 2022
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
* build docker image for feathr
* Add docker guidance to dev guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants