Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize purview query for getting features #584

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

enya-yx
Copy link
Collaborator

@enya-yx enya-yx commented Aug 16, 2022

Description

Resolves #564

  • Modify 'get_project_features' API to reduce time consuming
  • Main idea is calling only one purview client API to avoid too many HTTP requests
  • Performance comparison:
    Input
    start = time.time()
    features = registry.get_project_features("enya_test_registry")
    feature_list=list([to_camel(e.to_dict()) for e in features])
    print("duration1: ", time.time()-start)
    start = time.time()
    features = registry.get_project_features_origin("enya_test_registry")
    feature_list=list([to_camel(e.to_dict()) for e in features])
    print("duration2: ", time.time()-start)
    Output:
    duration1: 2.2548649311065674
    duration2: 16.783140897750854

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen added the safe to test Tag to execute build pipeline for a PR from forked repo label Aug 16, 2022
@xiaoyongzhu xiaoyongzhu merged commit bd89e61 into feathr-ai:main Aug 17, 2022
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
Co-authored-by: Enya-Yx <enya@Enyas-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants