Revert 756 #798
Merged
Revert 756 #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f7e1fd.
Yuqing-cat
approved these changes
Oct 31, 2022
blrchen
requested review from
Yuqing-cat and
enya-yx
and removed request for
enya-yx
enya-yx
approved these changes
Oct 31, 2022
loomlike
added a commit
to loomlike/feathr
that referenced
this pull request
Oct 31, 2022
This reverts commit ff438f5.
2 tasks
xiaoyongzhu
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Fix xdist test error. Also make a small cleanup some codes Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Revert "Revert 756 (#798)" This reverts commit ff438f5. * revert 798 (revert756 - example notebook refactor). Also add job_utils unit tests Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Update test_azure_spark_e2e.py * Fix doc dead links (#805) This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed. * Improve UI experience and clean up ui code warnings (#801) * Add DataSourcesSelect and FlowGraph and ResizeTable components. Fix all warning and lint issues. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Add CardDescriptions component and fix ESlint warning. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Update FeatureDetails page title. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Rename ProjectSelect Signed-off-by: Boli Guan <ifendoe@gmail.com> Signed-off-by: Boli Guan <ifendoe@gmail.com> * Add release instructions for Release Candidate (#809) * Add release instructions for Release Candidate * Add a section for release versioning * Add a section for overall process triggered by the release manager * Bump version to 0.9.0-rc1 (#810) * Fix tests to use mocks and fix get_result_df's databricks behavior Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * fix tem file to dir Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * checkout the feature_derivations.py from main (it was temporally changed to goaround previous issues) Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Remove old databricks sample notebook. Change pip install feathr from the github main branch to pickup the latest changes always Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Fix config and get_result_df for synapse * Fix generate_config to accept all the feathr env var config name Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Add more pytests Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Use None as default dataformat in the job_utils. Instead, set 'avro' as a default output format to the job tags from the client Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change feathr client to mocked object Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> * Change timeout to 1000s in the notebook Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Boli Guan <ifendoe@gmail.com> Co-authored-by: Blair Chen <blrchen@hotmail.com> Co-authored-by: Blair Chen <blrchen@users.noreply.github.com> Co-authored-by: Boli Guan <ifendoe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts PR #756 as it introduces a few new CI errors and make main branch broken. The reverted PR #756 can be postponed to next release with all CI test passed prior to merging.
databricks:====== 12 failed, 72 passed, 7 skipped, 74 warnings in 873.66s (0:14:33) =======synapse:====== 22 failed, 63 passed, 6 skipped, 16 warnings in 1478.44s (0:24:38) ======How was this PR tested?
After this PR, ci result is
======= 3 failed, 68 passed, 7 skipped, 58 warnings in 833.33s (0:13:53) =======The rest failure with [FEATHR_USER_ERROR] Fail to calculate derived feature List(f_trip_time_rounded) is a known issue which will be addressed in different PR. The testTimePartitionFeaturesSource issue is known too.
Does this PR introduce any user-facing changes?
No