Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only first Key will show even if multiple keys are added #837

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

Fendoe
Copy link
Contributor

@Fendoe Fendoe commented Nov 7, 2022

Signed-off-by: Boli Guan ifendoe@gmail.com

Description

Resolves #833

Fix showing multiple Entity Keys

image

Add Showing feature tags

image

Fix typo in Source Attributes

image

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

Signed-off-by: Boli Guan <ifendoe@gmail.com>
@xiaoyongzhu
Copy link
Member

@Fendoe if a feature is defined on two keys, how would that be displayed in the UI? Can you paste a screenshot for that?

@Fendoe
Copy link
Contributor Author

Fendoe commented Nov 7, 2022

@xiaoyongzhu

image

Signed-off-by: Boli Guan <ifendoe@gmail.com>
@blrchen blrchen merged commit b03932d into feathr-ai:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [UI] Only first Key will show even if multiple keys are added
3 participants