-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix register features #87
Conversation
tarockey
commented
Mar 23, 2022
- For issues:
- FeathrClient.register_features() does not raise error when build_features() has not been called. #84
- FeathrClient.register_features() only registers features from first auto_generated_*.conf in feature_conf folder #86
- Updates FeathrClient and _feature_registry to appropriate raise RuntimeErrors
- Updates _feature_registry to handle multiple .conf files in a single folder (as generated by build_features)
- Formatted templated .conf files to be more human readable
- Small formatting adjustments
No problem! Should I try and merge into a different branch so that the tests can be run before merging into main? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
@tarockey Thanks for the PR! I just merged it. |