Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix register features #87

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

tarockey
Copy link
Contributor

@xiaoyongzhu
Copy link
Member

Thanks for the PR! The test is failed because credentials are not spread to forked repo (will fix that hopefully soon), and others are all good to me. I've approved the changes and wait for @hangfei and @jaymo001 for their input on the string format changes.

xiaoyongzhu
xiaoyongzhu previously approved these changes Mar 23, 2022
feathr_project/feathr/_feature_registry.py Show resolved Hide resolved
@tarockey
Copy link
Contributor Author

Thanks for the PR! The test is failed because credentials are not spread to forked repo (will fix that hopefully soon), and others are all good to me. I've approved the changes and wait for @hangfei and @jaymo001 for their input on the string format changes.

No problem! Should I try and merge into a different branch so that the tests can be run before merging into main?

Copy link
Collaborator

@jaymo001 jaymo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@xiaoyongzhu xiaoyongzhu merged commit 83d597c into feathr-ai:main Mar 24, 2022
@xiaoyongzhu
Copy link
Member

@tarockey Thanks for the PR! I just merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants