Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job_tag to materialization job submission. #890

Merged

Conversation

loomlike
Copy link
Collaborator

Signed-off-by: Jun Ki Min 42475935+loomlike@users.noreply.github.com

Description

Add job_tag to materialization job submission.
Include output_path to job_tag when using an offline sink.

This PR fixes current CI test error.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

… arg order to make it work with old codes

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Nov 30, 2022
@xiaoyongzhu xiaoyongzhu merged commit 2d6da56 into feathr-ai:main Dec 1, 2022
jaymo001 pushed a commit that referenced this pull request Dec 7, 2022
… arg order to make it work with old codes (#890)

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants