Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty job tag #895

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

loomlike
Copy link
Collaborator

@loomlike loomlike commented Dec 2, 2022

Signed-off-by: Jun Ki Min 42475935+loomlike@users.noreply.github.com

Description

This is to fix nightly test failure. Seems the cause was when using online-sink and thus the output_path is None and
Databricks complains about None value tags.

How was this PR tested?

Tested with Databricks nightly test notebook.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Dec 2, 2022
@xiaoyongzhu xiaoyongzhu merged commit 1233653 into feathr-ai:main Dec 2, 2022
@loomlike loomlike deleted the jumin/fix_empty_job_tag branch December 2, 2022 18:29
jaymo001 pushed a commit that referenced this pull request Dec 7, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants