Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIRST aggregation for look up feature #917

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jaymo001
Copy link
Collaborator

Description

Currently, users are relying on UNION aggregation based look up feature, followed by a derived feature to pick the first value, when there is only one looked up feature value and the user wants to keep the look up feature value type the same as input.
This PR adds FIRST aggregation for look up feature so that users can skip the derived feature definition for such tasks.

How was this PR tested?

Add test case

@jaymo001 jaymo001 added the safe to test Tag to execute build pipeline for a PR from forked repo label Dec 12, 2022
Copy link
Collaborator

@bozhonghu bozhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should make it clear in documentation this should only be used if there is a single value and also make it clear this is only available in offline and not in online.

@xiaoyongzhu xiaoyongzhu merged commit 9c338bc into feathr-ai:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants