Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry when data loading fails #930

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

jaymo001
Copy link
Collaborator

@jaymo001 jaymo001 commented Dec 19, 2022

Description

  1. When source data loading fails, wait and retry 2 times before fail the job. This could happen as the source is still being generated.
  2. Fix test setup to enable Mockito Mock usage

How was this PR tested?

Add unit test

Does this PR introduce any user-facing changes?

No

@xiaoyongzhu
Copy link
Member

Thanks @jaymo001 ! can you merge main back to your branch just to make sure CI is OK? there are quite some bug fixes on main

@xiaoyongzhu xiaoyongzhu added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 21, 2023
Copy link
Collaborator

@bozhonghu bozhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyongzhu xiaoyongzhu merged commit dce3766 into feathr-ai:main Jan 27, 2023
jaymo001 added a commit to jaymo001/feathr that referenced this pull request Jan 30, 2023
jaymo001 added a commit to jaymo001/feathr that referenced this pull request Jan 30, 2023
xiaoyongzhu pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants