React best practice implementations in ui code #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fendoe
previously approved these changes
Jan 3, 2023
xiaoyongzhu
previously approved these changes
Jan 4, 2023
|
Please make sure it's tested to avoid breaking experience |
Yuqing-cat
approved these changes
Jan 4, 2023
windoze
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes many UI code but it does not introduce any user facing feature changes. This PR mainly bring react best practice into ui code.
@Fendoe, please help review this PR.
How was this PR tested?
Test locally with major features, no regression found.
Does this PR introduce any user-facing changes?
No