Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed !pip to %pip #963

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Changed !pip to %pip #963

merged 2 commits into from
Jan 15, 2023

Conversation

ahlag
Copy link
Contributor

@ahlag ahlag commented Jan 13, 2023

Description

Resolves #962

How was this PR tested?

Change

!pip install "feathr[notebook]"

to

%pip install "feathr[notebook]"

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@loomlike
Copy link
Collaborator

Thank you for the changes. Can you also update the same across other notebooks?

@ahlag
Copy link
Contributor Author

ahlag commented Jan 14, 2023

@loomlike
Yeah sure. Np!

@ahlag
Copy link
Contributor Author

ahlag commented Jan 14, 2023

@loomlike
Done

loomlike
loomlike approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 14, 2023
@blrchen blrchen merged commit 6eee8af into feathr-ai:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@loomlike loomlike loomlike approved these changes

@xiaoyongzhu xiaoyongzhu Awaiting requested review from xiaoyongzhu

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using %pip instead of !pip
3 participants
@ahlag @loomlike @blrchen