Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discretizers should be left inclusive #626

Closed
solegalli opened this issue Mar 7, 2023 · 0 comments · Fixed by #627
Closed

discretizers should be left inclusive #626

solegalli opened this issue Mar 7, 2023 · 0 comments · Fixed by #627

Comments

@solegalli
Copy link
Collaborator

we need to add include_lowest=True to base discretizer and make sure this does not break things. In theory, it shouldn't because the equal width and equal-frequency have -inf on the left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant