Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] switch include_lowest to True in discretizers #627

Merged
merged 8 commits into from
Mar 7, 2023

Conversation

solegalli
Copy link
Collaborator

@solegalli solegalli commented Mar 7, 2023

closes #626
closes #628

See for doc fix:
sphinx-doc/sphinx#11062

In case we need to revert

@solegalli solegalli changed the title switch include_lowest to True in discretizers [MRG] switch include_lowest to True in discretizers Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #627 (256514e) into main (71efa79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          96       96           
  Lines        3554     3554           
  Branches      685      685           
=======================================
  Hits         3479     3479           
  Misses         28       28           
  Partials       47       47           
Impacted Files Coverage Δ
feature_engine/discretisation/base_discretiser.py 100.00% <ø> (ø)
feature_engine/discretisation/equal_width.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs issue with favicons discretizers should be left inclusive
1 participant