Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the MinMaxScaler function #2

Closed
wants to merge 43 commits into from
Closed

Adding the MinMaxScaler function #2

wants to merge 43 commits into from

Conversation

joaopcnogueira
Copy link

I have added one implementation of the min-max scaler along with the unit test. The min-max scaler implemented scales all the selected features between 0 and 1.

@joaopcnogueira joaopcnogueira mentioned this pull request Mar 21, 2019
@solegalli
Copy link
Collaborator

Hi Joao,

Thanks for reaching out and making the PR.

Scikit-Learn has an implementation of the MinMaxScaler. Why would you like to have a separate one in feature_engine instead of using sklearn?

The idea of feature engine is to provide solutions that do not exist elsewhere.

Cheers.

@joaopcnogueira
Copy link
Author

joaopcnogueira commented Mar 22, 2019

Hi Solegalli,

I have been worked with feature_engine and I realized that it's amazing for custom pipelines. The MinMaxScaler does not have a parameter to pass the variables we want the scaler to act, so I thought I could implementing one with this parameter.

Edit: The MeanMedianImpyter class provides functionalities there are also present in the sklearn, with the class SimpleImputer.

@solegalli
Copy link
Collaborator

Yes, that is true.

I am thinking of adding a complete new class, called Scikit-learn wrapper or similar, that takes any (or as many as possible) sklearn feature engineering transformers, and apply it to selected group of features.

The code for that class is here:
https://github.com/trainindata/testing-and-monitoring-ml-deployments/blob/master/packages/gradient_boosting_model/gradient_boosting_model/processing/preprocessors.py#L5

Would you be happy to contribute with the addition of that piece of code to Feature-engine? If so, let me know and we get started by creating a separate issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants