Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROMO-251: Connect OpenGraph plugin to Docusaurus [part2; split of PR-368] #375

Merged
merged 14 commits into from
Jan 11, 2022
Merged

PROMO-251: Connect OpenGraph plugin to Docusaurus [part2; split of PR-368] #375

merged 14 commits into from
Jan 11, 2022

Conversation

Krakazybik
Copy link
Member

CHANGELOG

Split from: #368

Добавлено:

  • Файл конфигурации плагина OpenGraph.
  • Базовый шаблон плагина.
  • Meta OG ссылки на изображения для Doc страниц.
  • Подключение плагина в Docusaurus.

Чеклист

  • Если при работе с документацией потребовалось использовать github-дискуссии, то стоит их прикрепить как see-also источники
  • Если PR связан с задачей, то необходимо проверить, что все требования по задаче выполнены
  • Перед тем, как отправлять изменения на ревью, нужно ознакомиться с CONTIBUTING-гайдлайнами
  • Перед тем, как отправлять изменения на ревью, нужно провести self-review своих изменений
  • Перед тем, как отправлять изменения на ревью, нужно дождаться CI-проверок
  • Перед тем, как отправлять изменения на ревью, нужно дать краткое описание изменений

@azinit azinit linked an issue Dec 9, 2021 that may be closed by this pull request
PROMO: Add dynamic generation of social preview by article (for specific content) #251
Open
7 tasks
@azinit azinit changed the title FEAT(split-368): Connect OpenGraph plugin to Docusaurus. PROMO-251: Connect OpenGraph plugin to Docusaurus [part2; split of PR-368] Dec 9, 2021
@azinit
Copy link
Member

azinit commented Dec 12, 2021

Не забыть поправить работу с файлами)
#368 (review)

@Krakazybik Krakazybik mentioned this pull request Dec 23, 2021
Merged
6 tasks
@Krakazybik Krakazybik self-assigned this Dec 23, 2021
@Krakazybik Krakazybik requested a review from azinit December 23, 2021 13:25
azinit
azinit suggested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все в целом топчик, и понятно что многое будем лечить следующими итерациями

Но если сконцентрироваться на "Just подключить OG-плагин к докузавру", то несколько мест поправить бы и рассмотреть повнимательней)

(т.к. потом точно забудем)

website/.eslintrc.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/docusaurus.config.js Outdated Show resolved Hide resolved
website/open-graph-templates/basic/template.json Outdated Show resolved Hide resolved
website/open-graph-templates/basic/template.json Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
website/open-graph-templates/basic/template.json Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
@azinit azinit mentioned this pull request Dec 30, 2021
Open
7 tasks
@Krakazybik Krakazybik requested a review from azinit December 31, 2021 19:47
azinit
azinit approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо что зарезолвил все комментарии, стало однозначно лучше ! 🚀

website/plugins/docusaurus-plugin-og/index.js Show resolved Hide resolved
website/docusaurus.config.js Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Outdated Show resolved Hide resolved
website/src/theme/DocItem/lib/index.js Outdated Show resolved Hide resolved
website/src/theme/DocItem/index.js Show resolved Hide resolved
@azinit
Copy link
Member

azinit commented Jan 11, 2022

@feature-sliced/core @feature-sliced/contributors гляньте пож
Уже старый PR достаточно

@azinit azinit merged commit 1d164e5 into feature-sliced:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azinit azinit azinit approved these changes

@Postamentovich Postamentovich Postamentovich approved these changes

@tednaaa tednaaa Awaiting requested review from tednaaa

@GhostMayor GhostMayor Awaiting requested review from GhostMayor

@unordinarity unordinarity Awaiting requested review from unordinarity

@AlexandrHoroshih AlexandrHoroshih Awaiting requested review from AlexandrHoroshih

@spotsccc spotsccc Awaiting requested review from spotsccc

Assignees

@Krakazybik Krakazybik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PROMO: Add dynamic generation of social preview by article (for specific content)
4 participants
@Krakazybik @azinit @Postamentovich @tednaaa