Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guide example page translated into Korean #735

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Oct 13, 2024

I have translated the Guide page into Korean.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 98d20c2
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/671a56810560520008b9048f
😎 Deploy Preview https://deploy-preview-735--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Member

Thanks! Could you also ask someone from Discord to check these translations?

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Oct 13, 2024

@illright Got it, thank you.

/>
<NavCard
title="Page layouts"
description="FSD에서 타입을 어디에 배치하고 활용할지에 대한 가이드"
Copy link
Contributor

@movie42 movie42 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page layouts을 직접 번역하셨기 때문에 아시겠지만 번역된 description과 많이 다릅니다.
Types discription의 내용이 섞여 들어간것 같습니다. 원문 내용 확인하셔서 수정해주세요.

Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인부탁드립니다.

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Oct 24, 2024

@movie42 제가 타입쪽 description을 작성한 것 같네요. title에 맞게 다시 description을 수정했어요!

@Gaic4o Gaic4o requested a review from movie42 October 24, 2024 14:20
Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 👍

@illright illright merged commit 68cc55f into feature-sliced:master Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants