Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: community page translated into Korean #757

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 14, 2024

Background

We translated the Using with community page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 14, 2024

👷 Deploy request for pr-fsd accepted.

Name Link
🔨 Latest commit f33b4ad
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/6739bb3c7e304e00080ba36a

Copy link
Contributor

@movie42 movie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역해주셔서 감사합니다.

Comment on lines 16 to 21
<NavCard
title="커뮤니티 리소스와 추가 자료"
description="훌륭한 FSD 관련 비디오, 기사, 패키지를 모아둔 큐레이션 목록"
to="https://github.com/feature-sliced/awesome"
Icon={StarOutlined}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome이라는 레포지토리가 있는데 https://github.com/sindresorhus/awesome#readme

여기의 시리즈중 하나로 Awesome FSD가 있다는 것을 소개하고 있는 것으로 보입니다.

Awesome을 고유 대명사로 보고 'Awesome 자료' 또는 'Awesome 리소스'로 변경하는 것은 어떨지요?

아래 description에 대해서는 이견 없습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 거 같아요.. 감사합니다!

@movie42
Copy link
Contributor

movie42 commented Nov 22, 2024

Hello Maintainer,

I have completed the review of this translation, and the contributor has incorporated the suggested changes. Upon re-review, I did not find any issues. Please take a look when you have time.

Thank you!

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Nov 24, 2024

@illright

@illright illright merged commit 645c569 into feature-sliced:master Nov 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants