LINT-53(HOTFIX): PublicAPI for {segment}.* files #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Вроде как работает и тесты не обвалилсь =) |
azinit
suggested changes
Dec 22, 2021
rules/public-api/index.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| const { layersLib } = require("../../utils"); | |||
|
|
|||
| const FS_SEGMENTS_REG = layersLib.FS_SEGMENTS.join("|"); | |||
| const FS_SEGMENTS_REG = layersLib.FS_SEGMENTS.map(seg => `${seg}*`).join("|"); | |||
There was a problem hiding this comment.
issue: Контр пример
model // Pass (valid)
model.ts // Pass (valid)
models.ts // Pass (invalid)
model-data.ts // Pass (invalid)Тож самое и с другими сегментами можно провернуть)
suggestion: Кажется, нужно более явно указать, чтобы точка была 🤔
azinit
reviewed
Dec 22, 2021
rules/public-api/index.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| const { layersLib } = require("../../utils"); | |||
|
|
|||
| const FS_SEGMENTS_REG = layersLib.FS_SEGMENTS.join("|"); | |||
| const FS_SEGMENTS_REG = layersLib.FS_SEGMENTS.map(seg => `${seg}*`).join("|"); | |||
There was a problem hiding this comment.
nitpick: Ну и если по-хорошему, то как-то эту багу в тестах тоже отобразить бы - чтоб не воспроизводилась больше)
Мб прям явно в импортах написать тип "ui.tsx"
azinit
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
В регулярке добавлена проверка для {segment}.* файлов.
Reference
#53