Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play sound #651

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add play sound #651

wants to merge 6 commits into from

Conversation

yzyray
Copy link
Contributor

@yzyray yzyray commented Nov 1, 2019

No description provided.

@featurecat
Copy link
Owner

The sounds are so satisfying! However, it sounds a little bit laggy. For example, if I press the down arrow 3 times so that the next 3 moves are played, the sounds I hear do not correspond to exactly the amount of time I took to press all 3 moves. They sound combined together. Do you have any ideas on how to improve this before I merge?

@yzyray
Copy link
Contributor Author

yzyray commented Nov 1, 2019

The sounds are so satisfying! However, it sounds a little bit laggy. For example, if I press the down arrow 3 times so that the next 3 moves are played, the sounds I hear do not correspond to exactly the amount of time I took to press all 3 moves. They sound combined together. Do you have any ideas on how to improve this before I merge?

I made it on purpose,beacuse i find if play sound on every move,when we fastly jump many moves the sound effect will be very loud.so i set only play sound one time in 100 millisecond.

@featurecat
Copy link
Owner

Oh. I'll take a look when I have some time to see if I can improve it at all.

@kaorahi kaorahi mentioned this pull request Sep 28, 2020
@hope366 hope366 mentioned this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants