Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cf cli #6657

Merged
merged 1 commit into from
Feb 4, 2025
Merged

upgrade cf cli #6657

merged 1 commit into from
Feb 4, 2025

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Jan 29, 2025

Summary

The Cloud.gov v2 API for Cloud Foundry is reaching its end-of-life. CF CLI versions 6 and 7 still rely on Cloud Foundry API v2 and will no longer work at some point with foundations that have disabled it. However, CF CLI v8 no longer uses Cloud Foundry API v2. For more details, refer to this link.

  1. circleci/config.yml, is upgraded to CF CLI v8.9.0. This version supports Cloud Foundry API v3. Deploying to a cloud.gov space should work smoothly with this update

  2. Update node/npm combo to fix the node/npm inconsistencies in circleci. node v22.1.0 uses nvm 10.7.0.

  3. fec-pattern-library repo is also upgraded to use node v22.1.0 and nvm 10.7.0.

Required reviewers

1 developer

Impacted areas of the application

  • installs for deploy section
  • deploy cms section (to cloud.gov space)

Screenshots

Before:
cf cli v7.0.1 circleci build:

Screenshot 2025-01-29 at 3 45 34 PM

After:
cf cli v8.9.0. circleci build:

Screenshot 2025-01-29 at 3 43 47 PM Screenshot 2025-01-29 at 3 43 01 PM

Related PRs

Related PRs against other branches:

How to test

  • Follow these instructions to install cf CLI v8 on your local terminal or run: brew install cloudfoundry/tap/cf-cli@8
  • verify cf cli version: run cf version
F612211M:~ pkasireddy$ cf version
cf version 8.9.0+c23186c.2024-12-02
  • rerun this build in circleci
  • OR
  • create a test branch, update tasks.py(DEPLOY_RULES) with the test branch and deploy to dev space
  • Observe the following in circleci:
    1. In installs for deploy section, verify that cf cli v8.9.0 is downloaded and no errors there
    1. In deploy cms section, verify that cms app deployed to cloud.space successfully without any errors
    1. Indeploy cms section` confirm that cms app is using Cloud Foundry v3 API:
API endpoint:   https://api.fr.cloud.gov
API version:    3.185.0

@pkfec pkfec self-assigned this Jan 29, 2025
@pkfec pkfec marked this pull request as draft January 29, 2025 17:29
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (44c26c2) to head (1ace1ec).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6657   +/-   ##
========================================
  Coverage    79.67%   79.67%           
========================================
  Files          236      236           
  Lines         5172     5172           
========================================
  Hits          4121     4121           
  Misses        1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkfec pkfec changed the title uprade cf cli upgrade cf cli Jan 30, 2025
@pkfec pkfec marked this pull request as ready for review January 30, 2025 20:52
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@pkfec pkfec requested a review from cnlucas February 4, 2025 14:37
@pkfec pkfec force-pushed the feature/6110-upgrade-cf-cli branch from 1ace1ec to e2a59ca Compare February 4, 2025 14:41
Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pkfec

@cnlucas cnlucas merged commit 3fb1882 into develop Feb 4, 2025
3 checks passed
@cnlucas cnlucas deleted the feature/6110-upgrade-cf-cli branch February 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants