Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing contributor_aggregate_ytd #5765

Closed
1 task done
cnlucas opened this issue Mar 15, 2024 · 1 comment · Fixed by #6105
Closed
1 task done

Consider changing contributor_aggregate_ytd #5765

cnlucas opened this issue Mar 15, 2024 · 1 comment · Fixed by #6105
Assignees
Milestone

Comments

@cnlucas
Copy link
Member

cnlucas commented Mar 15, 2024

What we’re after

contributor_aggregate_ytd is per cycle if it's a Form 3 since 2000, but the field is the same for all other receipts where the field is actually per calendar year. This is a bit confusing and inaccurate for our users. We should consider having a separate field for cycle YTD. We should, if we can't do this, consider adding something to explain this issue.
https://api.open.fec.gov/v1/schedules/schedule_a/?two_year_transaction_period=2016&recipient_committee_designation=P&per_page=20&api_key=DEMO_KEY&sort=-contribution_receipt_date&sort_hide_null=false&sort_null_only=false

the form change information is here (thanks Dorothy!)

contributor_aggregate_ytd is per cycle for Form 3P.

Action item(s)

  • Update dosc.py and schemas.py
@cnlucas cnlucas moved this to 🔨 Pre-refinement in Website project Mar 15, 2024
@hcaofec hcaofec self-assigned this Jan 7, 2025
@hcaofec hcaofec added this to the 27.3 milestone Jan 7, 2025
@JonellaCulmer JonellaCulmer changed the title Consider changing contributor_aggregate_YTD Consider changing contributor_aggregate_ytd Jan 7, 2025
@hcaofec
Copy link
Contributor

hcaofec commented Jan 15, 2025

Considering the effort to add additional column to schedule A table, we can add description to clear up confusion.

The efforts include: both insert and output program will require big change, and external users will need to be informed and make corresponding changes on their side, and back-filling data is very challenging due to the amount of data.

@rfultz rfultz changed the title Consider changing contributor_aggregate_ytd Consider changing contributor_aggregate_ytd. Jan 21, 2025
@rfultz rfultz changed the title Consider changing contributor_aggregate_ytd. Consider changing contributor_aggregate_ytd Jan 21, 2025
@rfultz rfultz modified the milestones: 27.3, 27.4 Jan 21, 2025
@pkfec pkfec moved this from 🔨 Pre-refinement to 🏗 In Progress in Website project Jan 22, 2025
@pkfec pkfec moved this from 🏗 In Progress to 👀 Ready in Website project Jan 22, 2025
@github-project-automation github-project-automation bot moved this from 👀 Ready to ✅ Done in Website project Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants