Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to contributor_aggregate_ytd #6105

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

hcaofec
Copy link
Contributor

@hcaofec hcaofec commented Jan 17, 2025

Summary (required)

Add description to contributor_aggregate_ytd

Required reviewers

1 dev

How to test

  1. Download feature branch
  2. Run pytest
  3. Start API on local, and test with these endpoints. Scroll down and click on model to check the description.
  4. Schedule A endpoint, check contributor_aggregate_ytd
    http://127.0.0.1:5000/developers/#/receipts/get_v1_schedules_schedule_a_
Screenshot 2025-01-21 at 4 56 25 PM
  1. Election endpoint, check these two fields in model
    candidate_pcc_id
    candidate_pcc_name
    http://127.0.0.1:5000/developers/#/financial/get_v1_elections_

  2. /v1/totals/by_entity/, check end_date
    http://127.0.0.1:5000/developers/#/financial/get_v1_totals_by_entity_

@hcaofec hcaofec changed the title [WIP] Add description to contributor_aggregate_ytd Add description to contributor_aggregate_ytd Jan 22, 2025
@hcaofec hcaofec requested a review from fec-jli January 22, 2025 04:12
@hcaofec hcaofec force-pushed the feature/5765-add-docs-contributor-aggregate-ytd branch from 2392a99 to 5df232a Compare January 22, 2025 22:16
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (4420c97) to head (5df232a).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6105      +/-   ##
===========================================
+ Coverage    88.47%   88.49%   +0.02%     
===========================================
  Files           82       82              
  Lines         9142     9146       +4     
===========================================
+ Hits          8088     8094       +6     
+ Misses        1054     1052       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks

@fec-jli fec-jli merged commit 669f921 into develop Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Consider changing contributor_aggregate_ytd
2 participants