Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf]: component typings & fix select component multiple mode style err #233

Merged
merged 3 commits into from
May 29, 2022

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented May 29, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)
  • Fix select component in multiple mode display err.

Change information


This pr don't fix toast component. Because in next pr will refacotr toast component. :) And I think we should add lint & type check for fect. :)

@nonzzz nonzzz added bug Something isn't working feature labels May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #233 (65427b4) into master (f1fca03) will decrease coverage by 0.04%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   96.67%   96.63%   -0.05%     
==========================================
  Files         190      190              
  Lines        2136     2137       +1     
  Branches      373      373              
==========================================
  Hits         2065     2065              
- Misses         71       72       +1     
Impacted Files Coverage Δ
packages/vue/src/form-item/form-item.tsx 93.15% <0.00%> (-1.30%) ⬇️
packages/vue/src/select/props.ts 100.00% <ø> (ø)
packages/vue/src/avatar-group/avatar-context.ts 100.00% <100.00%> (ø)
packages/vue/src/badge-anchor/badge-context.ts 100.00% <100.00%> (ø)
...ackages/vue/src/breadcrumbs/breadcrumbs-context.ts 100.00% <100.00%> (ø)
...kages/vue/src/button-group/button-group-context.ts 100.00% <100.00%> (ø)
...ackages/vue/src/checkbox-group/checkbox-context.ts 100.00% <100.00%> (ø)
...ackages/vue/src/collapse-group/collapse-context.ts 100.00% <100.00%> (ø)
packages/vue/src/form/form-context.ts 100.00% <100.00%> (ø)
packages/vue/src/form/form.tsx 92.10% <100.00%> (ø)
... and 10 more

@nonzzz nonzzz merged commit 6577fc4 into fect-org:master May 29, 2022
@nonzzz nonzzz deleted the perf/tpings branch May 29, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant