Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf]: Toast component preformance. #234

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Conversation

nonzzz
Copy link
Collaborator

@nonzzz nonzzz commented May 31, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)
  • Remove inline style. use class name replace.
  • Add new API for toast.

Change information


@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #234 (1156cc5) into master (6d208fc) will decrease coverage by 0.10%.
The diff coverage is 81.25%.

❗ Current head 1156cc5 differs from pull request most recent head 5c3feee. Consider uploading reports for the commit 5c3feee to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   96.63%   96.52%   -0.11%     
==========================================
  Files         190      190              
  Lines        2137     2131       -6     
  Branches      373      372       -1     
==========================================
- Hits         2065     2057       -8     
- Misses         72       74       +2     
Impacted Files Coverage Δ
packages/vue/src/toast/toast.tsx 80.76% <68.75%> (-5.60%) ⬇️
packages/vue/src/toast/function-call.tsx 94.44% <91.66%> (-0.30%) ⬇️
packages/vue/src/toast/toast-contenxt.ts 100.00% <100.00%> (ø)
packages/vue/src/toast/toast-item.tsx 100.00% <100.00%> (ø)

@nonzzz nonzzz merged commit 3bc64e5 into fect-org:master Jun 2, 2022
@nonzzz nonzzz deleted the perf/logic branch June 2, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature perf Make code stronger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant