Support CMake build on MSVC #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
ghost
mentioned this pull request
|
For posterity, this works around what appears to be a long standing bug in the CMake crate: rust-lang/cmake-rs#18 |
benesch
added a commit
to benesch/rust-rdkafka
that referenced
this pull request
Dec 11, 2019
The approach in fede1024#176 to handle MSVC was flawed, as it did not properly account for CMake's RelWithDebInfo configuration type. The correct approach is to ask CMake to install the library, rather than just building it, at which point the library will be at a stable path (OUT_DIR/lib) regardless of the directory structure that the particular CMake generator uses. Fix fede1024#191.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on Windows with MSVC environment produce the library located at
build/src/Releaseorbuild/src/Debug, instead of justbuild/srcfor other environments.This PR explicitly handles this case. The choice between
ReleaseandDebughappens using the same logic as incmakecrate, see these lines.