Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the rust ecosystem uses
tracing
overlog
This branch adds an optional feature
tracing
tordkafka
that usestracing
log lines instead oflog
ones. See https://github.com/MaterializeInc/materialize/blob/883710649f95d232ead5872518969a15c1def542/src/kafka-util/src/client.rs#L28-L47 for an example of how people have to work around this, over using theDefaultClientContext
Some notes:
tracing::enabled!
is slightly different thanlog::log_enabled!
in that it doesn't query the tracing subscriber for specificallyEvent
type's. In practice, I have found this to be a vanishingly small difference, but with implementenabled_span
andenabled_event
tokio-rs/tracing#1900 this pr (after its landed, backported, and released), it could be possible to slightly improvetracing
log levels are consts, not variants, so I have to do some re-declaration to make them importable to make theenabled!
callsites as easy as possible to usecargo test/check
, but I need help setting up ci to exercise this