-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue: add reminder as FAB #642
Open
ahmedibrahim163
wants to merge
1
commit into
federicoiosue:develop
Choose a base branch
from
ahmedibrahim163:fix-add-reminder-as-FAB
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix issue: add reminder as FAB #642
ahmedibrahim163
wants to merge
1
commit into
federicoiosue:develop
from
ahmedibrahim163:fix-add-reminder-as-FAB
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi dear, thanks for the contribution! I gave a look to the code changes and it seems to me that you added a FAB element to the detail screen to add a new reminder but both modification and deletion are the same as before so the workflow change is currently partial. I'll keep this pull request waiting for new UI overhaul anyway, thanks! |
9198924
to
7844ad1
Compare
2b90b8c
to
404996a
Compare
3ad3295
to
bf2b2cb
Compare
433f05a
to
3c4531d
Compare
fd07c2c
to
0bb927a
Compare
8a8dab8
to
389fb4c
Compare
9d11b98
to
0f78b8c
Compare
73fc7a0
to
c87d5ee
Compare
cfb925a
to
db0286b
Compare
0f1f367
to
c8987f1
Compare
d78a98e
to
0168039
Compare
911df26
to
a6655ce
Compare
cbb03b8
to
11c97fd
Compare
2edb3a1
to
5a0bb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Federico Iosue,
Could you please revise my editing in order to fix issue: #368
Thanks in Advance