Changed the duration of no tags available message #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two other configurations for styles based on Crouton text duration, changed the duration of no tags available message from DURATION_SHORT(950ms) to DURATION_MEDIUM(1650ms) to fix issue federicoiosue#663
|
Hi Oscar, in which way this would fix the issue? Isn't that a matter of ratio of text and delimited space sizes? |
|
Hi Federico. In the additional context of Issue #663, Adeel mentioned that "it's difficult to read all of the text in the message within the duration as it is very less" so I added more configurational options for message text duration and changed the original duration. For the issue mentioned in the title - text cut, I tried to reproduce the issue across many types of emulators. I found text cut would not happen on most of them but only on Galaxy Nexus as Adeel said, so I didn't really change the original text size/space. |
federicoiosue
force-pushed
the
develop
branch
6 times, most recently
from
9d11b98
to
0f78b8c
Compare
federicoiosue
force-pushed
the
develop
branch
3 times, most recently
from
73fc7a0
to
c87d5ee
Compare
federicoiosue
force-pushed
the
develop
branch
4 times, most recently
from
cfb925a
to
db0286b
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
0f1f367
to
c8987f1
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
d78a98e
to
0168039
Compare
federicoiosue
force-pushed
the
develop
branch
4 times, most recently
from
bcb9823
to
c8bc0e6
Compare
federicoiosue
force-pushed
the
develop
branch
from
911df26
to
a6655ce
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
cbb03b8
to
11c97fd
Compare
federicoiosue
force-pushed
the
develop
branch
from
2edb3a1
to
5a0bb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two other configurations for styles based on Crouton text duration, changed the duration of no tags available message from DURATION_SHORT(950ms) to DURATION_MEDIUM(1650ms) to fix issue #663